POD version of TPCFastSpaceChargeCorrection#13301
POD version of TPCFastSpaceChargeCorrection#13301shahor02 wants to merge 2 commits intoAliceO2Group:devfrom
Conversation
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
Created from the TPCFastTransform using: std::vector<char> buff; // can be also pmr::vector from DPL make(..) const o2::gpu::TPCFastTransformPOD& pod = o2::gpu::TPCFastTransformPOD::create(buff, tpc_fast_transform); The buff vector will be expanded during creation and can be sent over DPL. On the receiving side, it should be cast as: const auto& podTransform = o2::gpu::TPCFastTransformPOD::get(pc.inputs().get<gsl::span<char>>(ref)); No initialization is needed, the transform methods (at the moment all methods of TPCFastSpaceChargeCorrection are implemented) can be directly queried from the object received over sh.memory. Add perfmormance test for pod map
|
Error while checking build/O2/fullCI for 73187e4 at 2025-01-16 05:20: Full log here. |
|
This PR did not have any update in the last 30 days. Is it still needed? Unless further action in will be closed in 5 days. |
|
Commenting to avoid closure |
davidrohr
left a comment
davidrohr
left a comment
There was a problem hiding this comment.
Looks good to me except that I do not understand why we would need a dictionary
| #pragma link C++ class o2::gpu::TPCFastTransformGeo::RowInfo + ; | ||
|
|
||
| #pragma link C++ class o2::gpu::TPCFastTransform + ; | ||
| #pragma link C++ class o2::gpu::TPCFastTransformPOD; |
There was a problem hiding this comment.
why do we create a dictionary if we never want to store this to file=
There was a problem hiding this comment.
It is handy for interactive root tests. You can remove it if you want.
|
ok then, I don't mind. we can merge it. |
|
It will likely conflict with the next commit from @sgorbuno and with the current TPCFastTransform we are anyway not going to use it. Should not we wait for the summable TPCFastTransform? |
|
@sgorbuno : This is Ruben's class for the in-memory flat representation of the TPC transformation without pointers. |
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
|
This PR did not have any update in the last 30 days. Is it still needed? Unless further action in will be closed in 5 days. |
|
REQUEST FOR PRODUCTION RELEASES: This will add The following labels are available |
3 participants
Created from the TPCFastTransform using:
The buff vector will be expanded during creation and can be sent over DPL. On the receiving side, it should be cast as:
No initialization is needed, the transform methods (at the moment all methods of TPCFastSpaceChargeCorrection are implemented) can be directly queried from the object received over sh.memory.